hoicil-spot-tf の規約を分析し、専用のピース・ファセットを作成。 plan → implement → 3並列レビュー → fix → COMPLETE のワークフロー。 カテゴリに「インフラストラクチャ」を追加。
1.3 KiB
1.3 KiB
Focus on reviewing Terraform convention compliance. Do not review AI-specific issues (already covered by the ai_review movement).
Review criteria:
- Variable declaration compliance (type, description, sensitive)
- Resource naming consistency (name_prefix pattern)
- File organization compliance (one file per concern)
- Security configurations (IMDSv2, encryption, access control, IAM least privilege)
- Tag management (default_tags, no duplication)
- Lifecycle rule appropriateness
- Cost trade-off documentation
- Unused variables / outputs / data sources
Previous finding tracking (required):
- First, extract open findings from "Previous Response"
- Assign
finding_idto each finding and classify current status asnew / persists / resolved - If status is
persists, provide concrete unresolved evidence (file/line)
Judgment Procedure
- First, extract previous open findings and preliminarily classify as
new / persists / resolved - Review the change diff and detect issues based on Terraform convention criteria
- Cross-check changes against REJECT criteria tables defined in knowledge
- For each detected issue, classify as blocking/non-blocking based on Policy's scope determination table and judgment rules
- If there is even one blocking issue (
neworpersists), judge as REJECT