takt/builtins/en/facets/instructions/review-requirements.md
nrslib 2dc5cf1102 feat: 全レビュアーに coder-decisions.md 参照を追加し設計判断の FP を抑制
意図的な設計判断をレビュアーが誤検知(FP)しないよう、全 review-*.md に
{report:coder-decisions.md} の参照セクションを追加。ただし設計判断自体の
妥当性も評価する指示を含め、盲目的な通過を防ぐ。
2026-03-04 14:40:01 +09:00

1.3 KiB

Review the changes from a requirements fulfillment perspective.

Review criteria:

  • Whether each requested requirement has been implemented
  • Whether implicit requirements (naturally expected behaviors) are satisfied
  • Whether changes outside the scope (scope creep) have crept in
  • Whether there are any partial or missing implementations

Design decisions reference: Review {report:coder-decisions.md} to understand the recorded design decisions.

  • Do not flag intentionally documented decisions as FP
  • However, also evaluate whether the design decisions themselves are sound, and flag any problems

Previous finding tracking (required):

  • First, extract open findings from "Previous Response"
  • Assign finding_id to each finding and classify current status as new / persists / resolved
  • If status is persists, provide concrete unresolved evidence (file/line)

Judgment Procedure

  1. Extract requirements one by one from the review target report and task
  2. For each requirement, identify the implementing code (file:line)
  3. Confirm that the code satisfies the requirement
  4. Check for any changes not covered by the requirements
  5. For each detected issue, classify as blocking/non-blocking based on Policy's scope determination table and judgment rules
  6. If there is even one blocking issue (new or persists), judge as REJECT