4e89fe1c23
- phase-runner: レポートを上書きせずタイムスタンプ付きで同ディレクトリに保存し、fix が過去指摘の傾向を追跡できるよう改善
- output-contracts: persists/reopened/family_tag フィールドを追加してレビュー指摘の継続性を明示
- pieces: 全ビルトインピースに reviewers↔fix の loop_monitors を追加し、発散ループを自動検知
- fix.md: 過去レポートの参照方法を「Glob で {レポート名}.* を検索、最大2件読む」と具体化
- loop-monitor-reviewers-fix.md: ループモニタ判定用の共通インストラクションを新規追加
47 lines
1.9 KiB
Markdown
47 lines
1.9 KiB
Markdown
```markdown
|
|
# Testing Review
|
|
|
|
## Result: APPROVE / REJECT
|
|
|
|
## Summary
|
|
{Summarize the result in 1-2 sentences}
|
|
|
|
## Reviewed Aspects
|
|
| Aspect | Result | Notes |
|
|
|--------|--------|-------|
|
|
| Test coverage | ✅ | - |
|
|
| Test structure (Given-When-Then) | ✅ | - |
|
|
| Test naming | ✅ | - |
|
|
| Test independence & reproducibility | ✅ | - |
|
|
| Mocks & fixtures | ✅ | - |
|
|
| Test strategy (unit/integration/E2E) | ✅ | - |
|
|
|
|
## Current Iteration Findings (new)
|
|
| # | finding_id | family_tag | Category | Location | Issue | Fix Suggestion |
|
|
|---|------------|------------|----------|----------|-------|----------------|
|
|
| 1 | TEST-NEW-src-test-L42 | test-structure | Coverage | `src/test.ts:42` | Issue description | Fix suggestion |
|
|
|
|
## Carry-over Findings (persists)
|
|
| # | finding_id | family_tag | Previous Evidence | Current Evidence | Issue | Fix Suggestion |
|
|
|---|------------|------------|-------------------|------------------|-------|----------------|
|
|
| 1 | TEST-PERSIST-src-test-L77 | test-structure | `src/test.ts:77` | `src/test.ts:77` | Unresolved | Fix suggestion |
|
|
|
|
## Resolved Findings (resolved)
|
|
| finding_id | Resolution Evidence |
|
|
|------------|---------------------|
|
|
| TEST-RESOLVED-src-test-L10 | `src/test.ts:10` now has sufficient coverage |
|
|
|
|
## Reopened Findings (reopened)
|
|
| # | finding_id | family_tag | Prior Resolution Evidence | Recurrence Evidence | Issue | Fix Suggestion |
|
|
|---|------------|------------|--------------------------|---------------------|-------|----------------|
|
|
| 1 | TEST-REOPENED-src-test-L55 | test-structure | `Previously fixed at src/test.ts:10` | `Recurred at src/test.ts:55` | Issue description | Fix approach |
|
|
|
|
## Rejection Gate
|
|
- REJECT is valid only when at least one finding exists in `new`, `persists`, or `reopened`
|
|
- Findings without `finding_id` are invalid
|
|
```
|
|
|
|
**Cognitive load reduction rules:**
|
|
- APPROVE: Summary only (5 lines or fewer)
|
|
- REJECT: Only relevant findings in tables (30 lines or fewer)
|