4e89fe1c23
- phase-runner: レポートを上書きせずタイムスタンプ付きで同ディレクトリに保存し、fix が過去指摘の傾向を追跡できるよう改善
- output-contracts: persists/reopened/family_tag フィールドを追加してレビュー指摘の継続性を明示
- pieces: 全ビルトインピースに reviewers↔fix の loop_monitors を追加し、発散ループを自動検知
- fix.md: 過去レポートの参照方法を「Glob で {レポート名}.* を検索、最大2件読む」と具体化
- loop-monitor-reviewers-fix.md: ループモニタ判定用の共通インストラクションを新規追加
48 lines
2.0 KiB
Markdown
48 lines
2.0 KiB
Markdown
```markdown
|
|
# Terraform Convention Review
|
|
|
|
## Result: APPROVE / REJECT
|
|
|
|
## Summary
|
|
{Summarize the result in 1-2 sentences}
|
|
|
|
## Reviewed Aspects
|
|
- [x] Variable declarations (type, description, sensitive)
|
|
- [x] Resource naming (name_prefix pattern)
|
|
- [x] File structure (one concern per file)
|
|
- [x] Security settings
|
|
- [x] Tag management
|
|
- [x] lifecycle rules
|
|
- [x] Cost trade-off documentation
|
|
|
|
## Current Iteration Findings (new)
|
|
| # | finding_id | family_tag | Scope | Location | Issue | Fix Suggestion |
|
|
|---|------------|------------|-------|----------|-------|----------------|
|
|
| 1 | TF-NEW-file-L42 | tf-convention | In-scope | `modules/example/main.tf:42` | Issue description | Fix approach |
|
|
|
|
Scope: "In-scope" (fixable in this change) / "Out-of-scope" (existing issue, non-blocking)
|
|
|
|
## Carry-over Findings (persists)
|
|
| # | finding_id | family_tag | Previous Evidence | Current Evidence | Issue | Fix Suggestion |
|
|
|---|------------|------------|-------------------|------------------|-------|----------------|
|
|
| 1 | TF-PERSIST-file-L77 | tf-convention | `file.tf:77` | `file.tf:77` | Still unresolved | Apply prior fix plan |
|
|
|
|
## Resolved Findings (resolved)
|
|
| finding_id | Resolution Evidence |
|
|
|------------|---------------------|
|
|
| TF-RESOLVED-file-L10 | `file.tf:10` now satisfies the convention |
|
|
|
|
## Reopened Findings (reopened)
|
|
| # | finding_id | family_tag | Prior Resolution Evidence | Recurrence Evidence | Issue | Fix Suggestion |
|
|
|---|------------|------------|--------------------------|---------------------|-------|----------------|
|
|
| 1 | TF-REOPENED-file-L55 | tf-convention | `Previously fixed at file.tf:10` | `Recurred at file.tf:55` | Issue description | Fix approach |
|
|
|
|
## Rejection Gate
|
|
- REJECT is valid only when at least one finding exists in `new`, `persists`, or `reopened`
|
|
- Findings without `finding_id` are invalid
|
|
```
|
|
|
|
**Cognitive load reduction rules:**
|
|
- APPROVE → Summary only (5 lines or fewer)
|
|
- REJECT → Include only relevant finding rows (30 lines or fewer)
|