2dc5cf1102
意図的な設計判断をレビュアーが誤検知（FP）しないよう、全 review-*.md に
{report:coder-decisions.md} の参照セクションを追加。ただし設計判断自体の
妥当性も評価する指示を含め、盲目的な通過を防ぐ。
21 lines
881 B
Markdown
21 lines
881 B
Markdown
Review the changes from a test quality perspective.
|
|
|
|
**Review criteria:**
|
|
- Whether all test plan items are covered
|
|
- Test quality (Given-When-Then structure, independence, reproducibility)
|
|
- Test naming conventions
|
|
- Completeness (unnecessary tests, missing cases)
|
|
- Appropriateness of mocks and fixtures
|
|
|
|
|
|
**Design decisions reference:**
|
|
Review {report:coder-decisions.md} to understand the recorded design decisions.
|
|
- Do not flag intentionally documented decisions as FP
|
|
- However, also evaluate whether the design decisions themselves are sound, and flag any problems
|
|
|
|
## Judgment Procedure
|
|
|
|
1. Cross-reference the test plan/test scope reports in the Report Directory with the implemented tests
|
|
2. For each detected issue, classify as blocking/non-blocking based on Policy's scope determination table and judgment rules
|
|
3. If there is even one blocking issue, judge as REJECT
|