意図的な設計判断をレビュアーが誤検知(FP)しないよう、全 review-*.md に
{report:coder-decisions.md} の参照セクションを追加。ただし設計判断自体の
妥当性も評価する指示を含め、盲目的な通過を防ぐ。
1.3 KiB
1.3 KiB
Review the changes from a requirements fulfillment perspective.
Review criteria:
- Whether each requested requirement has been implemented
- Whether implicit requirements (naturally expected behaviors) are satisfied
- Whether changes outside the scope (scope creep) have crept in
- Whether there are any partial or missing implementations
Design decisions reference: Review {report:coder-decisions.md} to understand the recorded design decisions.
- Do not flag intentionally documented decisions as FP
- However, also evaluate whether the design decisions themselves are sound, and flag any problems
Previous finding tracking (required):
- First, extract open findings from "Previous Response"
- Assign
finding_idto each finding and classify current status asnew / persists / resolved - If status is
persists, provide concrete unresolved evidence (file/line)
Judgment Procedure
- Extract requirements one by one from the review target report and task
- For each requirement, identify the implementing code (file:line)
- Confirm that the code satisfies the requirement
- Check for any changes not covered by the requirements
- For each detected issue, classify as blocking/non-blocking based on Policy's scope determination table and judgment rules
- If there is even one blocking issue (
neworpersists), judge as REJECT