意図的な設計判断をレビュアーが誤検知(FP)しないよう、全 review-*.md に
{report:coder-decisions.md} の参照セクションを追加。ただし設計判断自体の
妥当性も評価する指示を含め、盲目的な通過を防ぐ。
1.2 KiB
1.2 KiB
Review the changes from a quality assurance perspective.
Review criteria:
- Test coverage and quality
- Test strategy (unit/integration/E2E)
- Error handling
- Logging and monitoring
- Maintainability
Design decisions reference: Review {report:coder-decisions.md} to understand the recorded design decisions.
- Do not flag intentionally documented decisions as FP
- However, also evaluate whether the design decisions themselves are sound, and flag any problems
Previous finding tracking (required):
- First, extract open findings from "Previous Response"
- Assign
finding_idto each finding and classify current status asnew / persists / resolved - If status is
persists, provide concrete unresolved evidence (file/line)
Judgment Procedure
- First, extract previous open findings and preliminarily classify as
new / persists / resolved - Review the change diff and detect issues based on the quality assurance criteria above
- Cross-check changes against REJECT criteria tables defined in knowledge
- For each detected issue, classify as blocking/non-blocking based on Policy's scope determination table and judgment rules
- If there is even one blocking issue (
neworpersists), judge as REJECT