a8223d231d
Config: - PersistedGlobalConfig → GlobalConfig にリネーム、互換エイリアス削除 - persisted-global-config.ts → config-types.ts にリネーム - ProjectConfig → GlobalConfig extends Omit<ProjectConfig, ...> の継承構造に整理 - verbose/logLevel/log_level を削除（logging セクションに統一） - migration 機構（migratedProjectLocalKeys 等）を削除 Supervisor ペルソナ: - 後方互換コードの検出・その場しのぎの検出・ボーイスカウトルールを除去（review.md ポリシー / architecture.md ナレッジと重複） - ピース全体の見直しを supervise.md インストラクションに移動 takt-default-team-leader: - loop_monitor のインライン instruction_template を既存ファイル参照に変更 - implement の「判断できない」ルールを ai_review → plan に修正
75 lines
2.2 KiB
Markdown
75 lines
2.2 KiB
Markdown
Run tests, verify the build, and perform final approval.
|
|
|
|
**Overall piece verification:**
|
|
1. Check all reports in the report directory and verify overall piece consistency
|
|
- Does implementation match the plan?
|
|
- Were all review movement findings properly addressed?
|
|
- Was the original task objective achieved?
|
|
2. Whether each task spec requirement has been achieved
|
|
- Extract requirements one by one from the task spec
|
|
- For each requirement, identify the implementing code (file:line)
|
|
- Verify the code actually fulfills the requirement (read the file, run the test)
|
|
- Do not rely on the plan report's judgment; independently verify each requirement
|
|
- If any requirement is unfulfilled, REJECT
|
|
|
|
**Report verification:** Read all reports in the Report Directory and
|
|
check for any unaddressed improvement suggestions.
|
|
|
|
**Validation output contract:**
|
|
```markdown
|
|
# Final Verification Results
|
|
|
|
## Result: APPROVE / REJECT
|
|
|
|
## Requirements Fulfillment Check
|
|
|
|
Extract requirements from the task spec and verify each one individually against actual code.
|
|
|
|
| # | Requirement (extracted from task spec) | Met | Evidence (file:line) |
|
|
|---|---------------------------------------|-----|---------------------|
|
|
| 1 | {requirement 1} | ✅/❌ | `src/file.ts:42` |
|
|
| 2 | {requirement 2} | ✅/❌ | `src/file.ts:55` |
|
|
|
|
- If any ❌ exists, REJECT is mandatory
|
|
- ✅ without evidence is invalid (must verify against actual code)
|
|
- Do not rely on plan report's judgment; independently verify each requirement
|
|
|
|
## Verification Summary
|
|
| Item | Status | Verification method |
|
|
|------|--------|-------------------|
|
|
| Tests | ✅ | `npm test` (N passed) |
|
|
| Build | ✅ | `npm run build` succeeded |
|
|
| Functional check | ✅ | Main flows verified |
|
|
|
|
## Deliverables
|
|
- Created: {Created files}
|
|
- Modified: {Modified files}
|
|
|
|
## Outstanding items (if REJECT)
|
|
| # | Item | Reason |
|
|
|---|------|--------|
|
|
| 1 | {Item} | {Reason} |
|
|
```
|
|
|
|
**Summary output contract (only if APPROVE):**
|
|
```markdown
|
|
# Task Completion Summary
|
|
|
|
## Task
|
|
{Original request in 1-2 sentences}
|
|
|
|
## Result
|
|
Complete
|
|
|
|
## Changes
|
|
| Type | File | Summary |
|
|
|------|------|---------|
|
|
| Create | `src/file.ts` | Summary description |
|
|
|
|
## Verification commands
|
|
```bash
|
|
npm test
|
|
npm run build
|
|
```
|
|
```
|