provider event log default false

This commit is contained in:
nrslib 2026-02-11 16:32:11 +09:00
parent 21537a3214
commit 1705a33a88
5 changed files with 12 additions and 9 deletions

View File

@ -74,10 +74,10 @@ describe('E2E: Add task and run (takt add → takt run)', () => {
const readme = readFileSync(readmePath, 'utf-8');
expect(readme).toContain('E2E test passed');
// Verify task status became completed
// Verify completed task was removed from tasks.yaml
const tasksRaw = readFileSync(tasksFile, 'utf-8');
const parsed = parseYaml(tasksRaw) as { tasks?: Array<{ name?: string; status?: string }> };
const executed = parsed.tasks?.find((task) => task.name === 'e2e-test-task');
expect(executed?.status).toBe('completed');
expect(executed).toBeUndefined();
}, 240_000);
});

View File

@ -96,6 +96,6 @@ describe('E2E: Watch tasks (takt watch)', () => {
const tasksRaw = readFileSync(tasksFile, 'utf-8');
const parsed = parseYaml(tasksRaw) as { tasks?: Array<{ name?: string; status?: string }> };
const watchTask = parsed.tasks?.find((task) => task.name === 'watch-task');
expect(watchTask?.status).toBe('completed');
expect(watchTask).toBeUndefined();
}, 240_000);
});

View File

@ -20,10 +20,13 @@ describe('providerEventLogger', () => {
rmSync(tempDir, { recursive: true, force: true });
});
it('should enable provider events by default', () => {
expect(isProviderEventsEnabled()).toBe(true);
expect(isProviderEventsEnabled({})).toBe(true);
expect(isProviderEventsEnabled({ observability: {} })).toBe(true);
it('should disable provider events by default', () => {
expect(isProviderEventsEnabled()).toBe(false);
expect(isProviderEventsEnabled({})).toBe(false);
expect(isProviderEventsEnabled({ observability: {} })).toBe(false);
});
it('should enable provider events only when explicitly true', () => {
expect(isProviderEventsEnabled({ observability: { providerEvents: true } })).toBe(true);
});

View File

@ -22,7 +22,7 @@ export interface DebugConfig {
/** Observability configuration for runtime event logs */
export interface ObservabilityConfig {
/** Enable provider stream event logging (default: true when undefined) */
/** Enable provider stream event logging (default: false when undefined) */
providerEvents?: boolean;
}

View File

@ -133,5 +133,5 @@ export function isProviderEventsEnabled(config?: {
providerEvents?: boolean;
};
}): boolean {
return config?.observability?.providerEvents !== false;
return config?.observability?.providerEvents === true;
}