From 1705a33a88b4a5b98e9ca442ffe72d26d18677b6 Mon Sep 17 00:00:00 2001 From: nrslib <38722970+nrslib@users.noreply.github.com> Date: Wed, 11 Feb 2026 16:32:11 +0900 Subject: [PATCH] provider event log default false --- e2e/specs/add-and-run.e2e.ts | 4 ++-- e2e/specs/watch.e2e.ts | 2 +- src/__tests__/providerEventLogger.test.ts | 11 +++++++---- src/core/models/global-config.ts | 2 +- src/shared/utils/providerEventLogger.ts | 2 +- 5 files changed, 12 insertions(+), 9 deletions(-) diff --git a/e2e/specs/add-and-run.e2e.ts b/e2e/specs/add-and-run.e2e.ts index 3b7c47b..ac91c0e 100644 --- a/e2e/specs/add-and-run.e2e.ts +++ b/e2e/specs/add-and-run.e2e.ts @@ -74,10 +74,10 @@ describe('E2E: Add task and run (takt add → takt run)', () => { const readme = readFileSync(readmePath, 'utf-8'); expect(readme).toContain('E2E test passed'); - // Verify task status became completed + // Verify completed task was removed from tasks.yaml const tasksRaw = readFileSync(tasksFile, 'utf-8'); const parsed = parseYaml(tasksRaw) as { tasks?: Array<{ name?: string; status?: string }> }; const executed = parsed.tasks?.find((task) => task.name === 'e2e-test-task'); - expect(executed?.status).toBe('completed'); + expect(executed).toBeUndefined(); }, 240_000); }); diff --git a/e2e/specs/watch.e2e.ts b/e2e/specs/watch.e2e.ts index 29e0c18..f16318c 100644 --- a/e2e/specs/watch.e2e.ts +++ b/e2e/specs/watch.e2e.ts @@ -96,6 +96,6 @@ describe('E2E: Watch tasks (takt watch)', () => { const tasksRaw = readFileSync(tasksFile, 'utf-8'); const parsed = parseYaml(tasksRaw) as { tasks?: Array<{ name?: string; status?: string }> }; const watchTask = parsed.tasks?.find((task) => task.name === 'watch-task'); - expect(watchTask?.status).toBe('completed'); + expect(watchTask).toBeUndefined(); }, 240_000); }); diff --git a/src/__tests__/providerEventLogger.test.ts b/src/__tests__/providerEventLogger.test.ts index 08d361f..d2ac74a 100644 --- a/src/__tests__/providerEventLogger.test.ts +++ b/src/__tests__/providerEventLogger.test.ts @@ -20,10 +20,13 @@ describe('providerEventLogger', () => { rmSync(tempDir, { recursive: true, force: true }); }); - it('should enable provider events by default', () => { - expect(isProviderEventsEnabled()).toBe(true); - expect(isProviderEventsEnabled({})).toBe(true); - expect(isProviderEventsEnabled({ observability: {} })).toBe(true); + it('should disable provider events by default', () => { + expect(isProviderEventsEnabled()).toBe(false); + expect(isProviderEventsEnabled({})).toBe(false); + expect(isProviderEventsEnabled({ observability: {} })).toBe(false); + }); + + it('should enable provider events only when explicitly true', () => { expect(isProviderEventsEnabled({ observability: { providerEvents: true } })).toBe(true); }); diff --git a/src/core/models/global-config.ts b/src/core/models/global-config.ts index 89223a2..7ab9db5 100644 --- a/src/core/models/global-config.ts +++ b/src/core/models/global-config.ts @@ -22,7 +22,7 @@ export interface DebugConfig { /** Observability configuration for runtime event logs */ export interface ObservabilityConfig { - /** Enable provider stream event logging (default: true when undefined) */ + /** Enable provider stream event logging (default: false when undefined) */ providerEvents?: boolean; } diff --git a/src/shared/utils/providerEventLogger.ts b/src/shared/utils/providerEventLogger.ts index 70b3630..0789e90 100644 --- a/src/shared/utils/providerEventLogger.ts +++ b/src/shared/utils/providerEventLogger.ts @@ -133,5 +133,5 @@ export function isProviderEventsEnabled(config?: { providerEvents?: boolean; }; }): boolean { - return config?.observability?.providerEvents !== false; + return config?.observability?.providerEvents === true; }