ea7ce54912
## 概要
`resources/` ディレクトリを `builtins/` にリネームし、用途を明確化。同時に export-cc コマンドを拡張して全リソースをコピーするように修正する。
---
## タスク一覧
### 1. ディレクトリリネーム（優先度: 高）
| 変更前 | 変更後 |
|--------|--------|
| `resources/` | `builtins/` |
| `resources/global/{lang}/` | `builtins/{lang}/`（global/ 階層を除去） |
| `resources/project/` | `builtins/project/` |
| `resources/skill/` | `builtins/skill/` |
### 2. 不要ファイル削除（優先度: 高）
- `builtins/{lang}/prompts/` を削除
- 対象: `interactive-system.md`, `interactive-summary.md`
- 理由: コードから未参照、実体は `src/shared/prompts/`
### 3. コード修正 — パス参照（優先度: 高）
`resources` → `builtins`、`global/{lang}` → `{lang}` に更新:
| ファイル | 修正内容 |
|----------|----------|
| `src/infra/resources/index.ts` | `getResourcesDir()`, `getGlobalResourcesDir()`, `getLanguageResourcesDir()` 等のパス |
| `src/infra/config/paths.ts` | `getBuiltinPiecesDir()`, `getBuiltinPersonasDir()` |
| `src/infra/config/global/initialization.ts` | `copyLanguageConfigYaml()` |
| `src/infra/config/loaders/pieceCategories.ts` | `getLanguageResourcesDir()` 参照 |
| `src/features/config/ejectBuiltin.ts` | `getLanguageResourcesDir()` 参照 |
| `src/features/config/deploySkill.ts` | `getResourcesDir()` 参照 |
### 4. export-cc 修正（優先度: 高）
ファイル: `src/features/config/deploySkill.ts`
**現状**: pieces/ と personas/ のみコピー
**修正後**:
- `builtins/{lang}/` 全体を `~/.claude/skills/takt/` にコピー
- `skill/` のファイル（SKILL.md, references/, takt-command.md）は従来通り
- サマリー表示を新リソースタイプ（stances, instructions, knowledge 等）に対応
- confirm メッセージ修正:
- 現状: `'上書きしますか？'`
- 修正後: `'既存のスキルファイルをすべて削除し、最新版に置き換えます。続行しますか？'`
### 5. テスト修正（優先度: 中）
| ファイル | 修正内容 |
|----------|----------|
| `src/__tests__/initialization.test.ts` | `getLanguageResourcesDir` のパス期待値 |
| `src/__tests__/piece-category-config.test.ts` | mock パス |
| その他 `resources` パスを参照しているテスト | パス更新 |
### 6. ビルド・パッケージ設定（優先度: 中）
| ファイル | 修正内容 |
|----------|----------|
| `package.json` | `files` フィールドで `resources/` → `builtins/` |
| `tsconfig.json` | `resources/` への参照があれば更新 |
| `.gitignore` | 必要に応じて更新 |
### 7. ドキュメント（優先度: 低）
- `CLAUDE.md` の Directory Structure セクションを更新
- JSDoc コメントから `prompts/` 記述を削除
---
## 制約
- `builtins/{lang}/` のフラット構造は変更不可（ピースYAML内の相対パス依存）
- eject のセーフティ（skip-if-exists）は変更不要
- export-cc のセーフティ（SKILL.md 存在チェック + confirm）は維持
---
## 確認方法
- `npm run build` が成功すること
- `npm test` が全てパスすること
- `takt init` / `takt eject` / `takt export-cc` が正常動作すること
350 lines
9.2 KiB
YAML
350 lines
9.2 KiB
YAML
# Expert Review Piece
|
||
# アーキテクチャ、フロントエンド、セキュリティ、QAの専門家によるレビューピース
|
||
#
|
||
# フロー:
|
||
# plan -> implement -> ai_review -> reviewers (parallel) -> supervise -> COMPLETE
|
||
# ↓ ├─ arch-review ↓
|
||
# ai_fix ├─ frontend-review fix_supervisor
|
||
# ├─ security-review
|
||
# └─ qa-review
|
||
# any("needs_fix") → fix → reviewers
|
||
#
|
||
# テンプレート変数:
|
||
# {iteration} - ピース全体のターン数（全エージェントで実行されたムーブメントの合計）
|
||
# {max_iterations} - ピースの最大イテレーション数
|
||
# {movement_iteration} - ムーブメントごとのイテレーション数（このムーブメントが何回実行されたか）
|
||
# {task} - 元のユーザー要求
|
||
# {previous_response} - 前のムーブメントの出力
|
||
# {user_inputs} - ピース中に蓄積されたユーザー入力
|
||
# {report_dir} - レポートディレクトリ名（例: "20250126-143052-task-summary"）
|
||
|
||
name: expert
|
||
description: アーキテクチャ・フロントエンド・セキュリティ・QA専門家レビュー
|
||
|
||
max_iterations: 30
|
||
|
||
stances:
|
||
coding: ../stances/coding.md
|
||
review: ../stances/review.md
|
||
testing: ../stances/testing.md
|
||
|
||
knowledge:
|
||
frontend: ../knowledge/frontend.md
|
||
security: ../knowledge/security.md
|
||
architecture: ../knowledge/architecture.md
|
||
|
||
personas:
|
||
planner: ../personas/planner.md
|
||
coder: ../personas/coder.md
|
||
ai-antipattern-reviewer: ../personas/ai-antipattern-reviewer.md
|
||
architecture-reviewer: ../personas/architecture-reviewer.md
|
||
frontend-reviewer: ../personas/frontend-reviewer.md
|
||
security-reviewer: ../personas/security-reviewer.md
|
||
qa-reviewer: ../personas/qa-reviewer.md
|
||
expert-supervisor: ../personas/expert-supervisor.md
|
||
|
||
instructions:
|
||
plan: ../instructions/plan.md
|
||
implement: ../instructions/implement.md
|
||
ai-review: ../instructions/ai-review.md
|
||
ai-fix: ../instructions/ai-fix.md
|
||
arbitrate: ../instructions/arbitrate.md
|
||
review-arch: ../instructions/review-arch.md
|
||
review-frontend: ../instructions/review-frontend.md
|
||
review-security: ../instructions/review-security.md
|
||
review-qa: ../instructions/review-qa.md
|
||
fix: ../instructions/fix.md
|
||
supervise: ../instructions/supervise.md
|
||
fix-supervisor: ../instructions/fix-supervisor.md
|
||
|
||
report_formats:
|
||
plan: ../report-formats/plan.md
|
||
ai-review: ../report-formats/ai-review.md
|
||
architecture-review: ../report-formats/architecture-review.md
|
||
frontend-review: ../report-formats/frontend-review.md
|
||
security-review: ../report-formats/security-review.md
|
||
qa-review: ../report-formats/qa-review.md
|
||
validation: ../report-formats/validation.md
|
||
summary: ../report-formats/summary.md
|
||
|
||
initial_movement: plan
|
||
|
||
movements:
|
||
# ===========================================
|
||
# Movement 0: Planning
|
||
# ===========================================
|
||
- name: plan
|
||
edit: false
|
||
persona: planner
|
||
report:
|
||
name: 00-plan.md
|
||
format: plan
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
- Bash
|
||
- WebSearch
|
||
- WebFetch
|
||
instruction: plan
|
||
rules:
|
||
- condition: タスク分析と計画が完了した
|
||
next: implement
|
||
- condition: 要件が不明確で計画を立てられない
|
||
next: ABORT
|
||
|
||
# ===========================================
|
||
# Movement 1: Implementation
|
||
# ===========================================
|
||
- name: implement
|
||
edit: true
|
||
persona: coder
|
||
stance:
|
||
- coding
|
||
- testing
|
||
session: refresh
|
||
report:
|
||
- Scope: 01-coder-scope.md
|
||
- Decisions: 02-coder-decisions.md
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
- Edit
|
||
- Write
|
||
- Bash
|
||
- WebSearch
|
||
- WebFetch
|
||
instruction: implement
|
||
rules:
|
||
- condition: 実装が完了した
|
||
next: ai_review
|
||
- condition: 実装未着手（レポートのみ）
|
||
next: ai_review
|
||
- condition: 実装を進行できない
|
||
next: ai_review
|
||
- condition: ユーザー入力が必要
|
||
next: implement
|
||
requires_user_input: true
|
||
interactive_only: true
|
||
|
||
# ===========================================
|
||
# Movement 2: AI Review
|
||
# ===========================================
|
||
- name: ai_review
|
||
edit: false
|
||
persona: ai-antipattern-reviewer
|
||
stance: review
|
||
report:
|
||
name: 03-ai-review.md
|
||
format: ai-review
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
- WebSearch
|
||
- WebFetch
|
||
instruction: ai-review
|
||
rules:
|
||
- condition: AI特有の問題が見つからない
|
||
next: reviewers
|
||
- condition: AI特有の問題が検出された
|
||
next: ai_fix
|
||
|
||
- name: ai_fix
|
||
edit: true
|
||
persona: coder
|
||
stance:
|
||
- coding
|
||
- testing
|
||
session: refresh
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
- Edit
|
||
- Write
|
||
- Bash
|
||
- WebSearch
|
||
- WebFetch
|
||
instruction: ai-fix
|
||
rules:
|
||
- condition: AI Reviewerの指摘に対する修正が完了した
|
||
next: ai_review
|
||
- condition: 修正不要（指摘対象ファイル/仕様の確認済み）
|
||
next: ai_no_fix
|
||
- condition: 修正を進行できない
|
||
next: ai_no_fix
|
||
|
||
- name: ai_no_fix
|
||
edit: false
|
||
persona: architecture-reviewer
|
||
stance: review
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
rules:
|
||
- condition: ai_reviewの指摘が妥当（修正すべき）
|
||
next: ai_fix
|
||
- condition: ai_fixの判断が妥当（修正不要）
|
||
next: reviewers
|
||
instruction: arbitrate
|
||
|
||
# ===========================================
|
||
# Movement 3: Expert Reviews (Parallel)
|
||
# ===========================================
|
||
- name: reviewers
|
||
parallel:
|
||
- name: arch-review
|
||
edit: false
|
||
persona: architecture-reviewer
|
||
stance: review
|
||
knowledge: architecture
|
||
report:
|
||
name: 04-architect-review.md
|
||
format: architecture-review
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
|
||
- WebSearch
|
||
- WebFetch
|
||
rules:
|
||
- condition: approved
|
||
- condition: needs_fix
|
||
instruction: review-arch
|
||
|
||
- name: frontend-review
|
||
edit: false
|
||
persona: frontend-reviewer
|
||
stance: review
|
||
knowledge: frontend
|
||
report:
|
||
name: 05-frontend-review.md
|
||
format: frontend-review
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
|
||
- WebSearch
|
||
- WebFetch
|
||
rules:
|
||
- condition: approved
|
||
- condition: needs_fix
|
||
instruction: review-frontend
|
||
|
||
- name: security-review
|
||
edit: false
|
||
persona: security-reviewer
|
||
stance: review
|
||
knowledge: security
|
||
report:
|
||
name: 06-security-review.md
|
||
format: security-review
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
|
||
- WebSearch
|
||
- WebFetch
|
||
rules:
|
||
- condition: approved
|
||
- condition: needs_fix
|
||
instruction: review-security
|
||
|
||
- name: qa-review
|
||
edit: false
|
||
persona: qa-reviewer
|
||
stance: review
|
||
report:
|
||
name: 07-qa-review.md
|
||
format: qa-review
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
|
||
- WebSearch
|
||
- WebFetch
|
||
rules:
|
||
- condition: approved
|
||
- condition: needs_fix
|
||
instruction: review-qa
|
||
rules:
|
||
- condition: all("approved")
|
||
next: supervise
|
||
- condition: any("needs_fix")
|
||
next: fix
|
||
|
||
- name: fix
|
||
edit: true
|
||
persona: coder
|
||
stance:
|
||
- coding
|
||
- testing
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
- Edit
|
||
- Write
|
||
- Bash
|
||
- WebSearch
|
||
- WebFetch
|
||
permission_mode: edit
|
||
rules:
|
||
- condition: 修正が完了した
|
||
next: reviewers
|
||
- condition: 修正を進行できない
|
||
next: plan
|
||
instruction: fix
|
||
|
||
# ===========================================
|
||
# Movement 4: Supervision
|
||
# ===========================================
|
||
- name: supervise
|
||
edit: false
|
||
persona: expert-supervisor
|
||
stance: review
|
||
report:
|
||
- Validation: 08-supervisor-validation.md
|
||
- Summary: summary.md
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
- WebSearch
|
||
- WebFetch
|
||
instruction: supervise
|
||
rules:
|
||
- condition: すべての検証が完了し、マージ可能な状態である
|
||
next: COMPLETE
|
||
- condition: 問題が検出された
|
||
next: fix_supervisor
|
||
|
||
- name: fix_supervisor
|
||
edit: true
|
||
persona: coder
|
||
stance:
|
||
- coding
|
||
- testing
|
||
allowed_tools:
|
||
- Read
|
||
- Glob
|
||
- Grep
|
||
- Edit
|
||
- Write
|
||
- Bash
|
||
- WebSearch
|
||
- WebFetch
|
||
instruction: fix-supervisor
|
||
rules:
|
||
- condition: 監督者の指摘に対する修正が完了した
|
||
next: supervise
|
||
- condition: 修正を進行できない
|
||
next: plan
|