133 lines
3.9 KiB
TypeScript
133 lines
3.9 KiB
TypeScript
/**
|
|
* Tests for WorkflowEngine provider/model overrides.
|
|
*
|
|
* Verifies that CLI-specified overrides take precedence over workflow movement defaults,
|
|
* and that movement-specific values are used when no overrides are present.
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach, vi } from 'vitest';
|
|
|
|
vi.mock('../agents/runner.js', () => ({
|
|
runAgent: vi.fn(),
|
|
}));
|
|
|
|
vi.mock('../core/workflow/evaluation/index.js', () => ({
|
|
detectMatchedRule: vi.fn(),
|
|
}));
|
|
|
|
vi.mock('../core/workflow/phase-runner.js', () => ({
|
|
needsStatusJudgmentPhase: vi.fn(),
|
|
runReportPhase: vi.fn(),
|
|
runStatusJudgmentPhase: vi.fn(),
|
|
}));
|
|
|
|
vi.mock('../shared/utils/index.js', async (importOriginal) => ({
|
|
...(await importOriginal<Record<string, unknown>>()),
|
|
generateReportDir: vi.fn().mockReturnValue('test-report-dir'),
|
|
}));
|
|
|
|
import { WorkflowEngine } from '../core/workflow/index.js';
|
|
import { runAgent } from '../agents/runner.js';
|
|
import type { WorkflowConfig } from '../core/models/index.js';
|
|
import {
|
|
makeResponse,
|
|
makeRule,
|
|
makeMovement,
|
|
mockRunAgentSequence,
|
|
mockDetectMatchedRuleSequence,
|
|
applyDefaultMocks,
|
|
} from './engine-test-helpers.js';
|
|
|
|
describe('WorkflowEngine agent overrides', () => {
|
|
beforeEach(() => {
|
|
vi.resetAllMocks();
|
|
applyDefaultMocks();
|
|
});
|
|
|
|
it('respects workflow movement provider/model even when CLI overrides are provided', async () => {
|
|
const movement = makeMovement('plan', {
|
|
provider: 'claude',
|
|
model: 'claude-movement',
|
|
rules: [makeRule('done', 'COMPLETE')],
|
|
});
|
|
const config: WorkflowConfig = {
|
|
name: 'override-test',
|
|
movements: [movement],
|
|
initialMovement: 'plan',
|
|
maxIterations: 1,
|
|
};
|
|
|
|
mockRunAgentSequence([
|
|
makeResponse({ agent: movement.agent, content: 'done' }),
|
|
]);
|
|
mockDetectMatchedRuleSequence([{ index: 0, method: 'phase1_tag' }]);
|
|
|
|
const engine = new WorkflowEngine(config, '/tmp/project', 'override task', {
|
|
projectCwd: '/tmp/project',
|
|
provider: 'codex',
|
|
model: 'cli-model',
|
|
});
|
|
|
|
await engine.run();
|
|
|
|
const options = vi.mocked(runAgent).mock.calls[0][2];
|
|
expect(options.provider).toBe('claude');
|
|
expect(options.model).toBe('claude-movement');
|
|
});
|
|
|
|
it('allows CLI overrides when workflow movement leaves provider/model undefined', async () => {
|
|
const movement = makeMovement('plan', {
|
|
rules: [makeRule('done', 'COMPLETE')],
|
|
});
|
|
const config: WorkflowConfig = {
|
|
name: 'override-fallback',
|
|
movements: [movement],
|
|
initialMovement: 'plan',
|
|
maxIterations: 1,
|
|
};
|
|
|
|
mockRunAgentSequence([
|
|
makeResponse({ agent: movement.agent, content: 'done' }),
|
|
]);
|
|
mockDetectMatchedRuleSequence([{ index: 0, method: 'phase1_tag' }]);
|
|
|
|
const engine = new WorkflowEngine(config, '/tmp/project', 'override task', {
|
|
projectCwd: '/tmp/project',
|
|
provider: 'codex',
|
|
model: 'cli-model',
|
|
});
|
|
|
|
await engine.run();
|
|
|
|
const options = vi.mocked(runAgent).mock.calls[0][2];
|
|
expect(options.provider).toBe('codex');
|
|
expect(options.model).toBe('cli-model');
|
|
});
|
|
|
|
it('falls back to workflow movement provider/model when no overrides supplied', async () => {
|
|
const movement = makeMovement('plan', {
|
|
provider: 'claude',
|
|
model: 'movement-model',
|
|
rules: [makeRule('done', 'COMPLETE')],
|
|
});
|
|
const config: WorkflowConfig = {
|
|
name: 'movement-defaults',
|
|
movements: [movement],
|
|
initialMovement: 'plan',
|
|
maxIterations: 1,
|
|
};
|
|
|
|
mockRunAgentSequence([
|
|
makeResponse({ agent: movement.agent, content: 'done' }),
|
|
]);
|
|
mockDetectMatchedRuleSequence([{ index: 0, method: 'phase1_tag' }]);
|
|
|
|
const engine = new WorkflowEngine(config, '/tmp/project', 'movement task', { projectCwd: '/tmp/project' });
|
|
await engine.run();
|
|
|
|
const options = vi.mocked(runAgent).mock.calls[0][2];
|
|
expect(options.provider).toBe('claude');
|
|
expect(options.model).toBe('movement-model');
|
|
});
|
|
});
|