takt/builtins/en/pieces/review-only.yaml
nrslib 1466a7176d takt: # タスク指示書: Output Contracts と Quality Gates の実装
## 概要
仕様ドキュメント `/Users/m_naruse/work/git/takt/task_planning/output-contracts-and-quality-gates.md` に基づき、YAML構造の変更を実装する。

---

## タスク一覧

### 【高】トップレベル構造の変更
- 現在の `output_contracts` を `report_formats` にリネーム
- レポートテンプレート定義として機能させる

### 【高】Movement内の output_contracts 構造変更
- 各 movement の `output_contracts` が直接レポート配列を持つ構造に変更
- `output_contracts.report` の `report` キーを廃止

**変更後の構造:**
```yaml
report_formats:           # トップレベル(テンプレート定義)
  plan: ...

movements:
  - name: plan
    output_contracts:     # 直接配列(reportキー不要)
      - name: 00-plan.md
        format: plan
```

### 【中】quality_gates の実装
- エージェントへの通達として機能させる(自動検証は将来実装)
- Movement完了時にエージェントが参照できる形式で定義

---

## 制約(ユーザー明示)
- 後方互換性は不要

---

## 確認方法
- 既存のピース定義YAMLが新構造でパースできること
- テストが通ること
2026-02-07 22:03:43 +09:00

234 lines
6.9 KiB
YAML

name: review-only
description: Review-only piece - reviews code without making edits
max_iterations: 10
policies:
review: ../policies/review.md
ai-antipattern: ../policies/ai-antipattern.md
knowledge:
architecture: ../knowledge/architecture.md
security: ../knowledge/security.md
personas:
planner: ../personas/planner.md
architecture-reviewer: ../personas/architecture-reviewer.md
security-reviewer: ../personas/security-reviewer.md
ai-antipattern-reviewer: ../personas/ai-antipattern-reviewer.md
supervisor: ../personas/supervisor.md
pr-commenter: ../personas/pr-commenter.md
instructions:
review-arch: ../instructions/review-arch.md
review-security: ../instructions/review-security.md
review-ai: ../instructions/review-ai.md
initial_movement: plan
movements:
- name: plan
edit: false
persona: planner
allowed_tools:
- Read
- Glob
- Grep
- WebSearch
- WebFetch
rules:
- condition: Review scope is clear
next: reviewers
- condition: User is asking a question (not a review task)
next: COMPLETE
- condition: Requirements unclear, insufficient info
next: ABORT
appendix: |
Clarifications needed:
- {Question 1}
- {Question 2}
instruction_template: |
## Previous Response (when returned from supervise)
{previous_response}
Analyze the review request and create a review plan.
**This is a review-only piece.** No code edits will be made.
Focus on:
1. Identify which files/modules to review
2. Determine review focus areas (architecture, security, AI patterns, etc.)
3. Note any specific concerns mentioned in the request
**If a PR number is mentioned** (e.g., "PR #42"), include it in your plan
so reviewers can focus on the PR's changed files.
- name: reviewers
parallel:
- name: arch-review
edit: false
persona: architecture-reviewer
policy: review
knowledge: architecture
allowed_tools:
- Read
- Glob
- Grep
- WebSearch
- WebFetch
rules:
- condition: approved
- condition: needs_fix
instruction: review-arch
output_contracts:
- name: 01-architect-review.md
format: architecture-review
- name: security-review
edit: false
persona: security-reviewer
policy: review
knowledge: security
allowed_tools:
- Read
- Glob
- Grep
- WebSearch
- WebFetch
rules:
- condition: approved
- condition: needs_fix
instruction: review-security
output_contracts:
- name: 02-security-review.md
format: security-review
- name: ai-review
edit: false
persona: ai-antipattern-reviewer
policy:
- review
- ai-antipattern
allowed_tools:
- Read
- Glob
- Grep
- WebSearch
- WebFetch
rules:
- condition: approved
- condition: needs_fix
instruction: review-ai
output_contracts:
- name: 03-ai-review.md
format: ai-review
rules:
- condition: all("approved")
next: supervise
- condition: any("needs_fix")
next: supervise
- name: supervise
edit: false
persona: supervisor
policy: review
allowed_tools:
- Read
- Glob
- Grep
- WebSearch
- WebFetch
rules:
- condition: approved, PR comment requested
next: pr-comment
- condition: approved
next: COMPLETE
- condition: rejected
next: ABORT
instruction_template: |
## Review Results
{previous_response}
**This is a review-only piece.** Do NOT run tests or builds.
Your role is to synthesize the review results and produce a final summary.
**Tasks:**
1. Read all review reports in the Report Directory
2. Synthesize findings from architecture, security, and AI reviews
3. Produce a consolidated review summary with overall verdict
4. Determine routing:
- If the task mentions posting to a PR (e.g., "post comments to PR", "comment on PR"),
route to `pr-comment` movement (condition: "approved, PR comment requested")
- If local review only, route to COMPLETE (condition: "approved")
- If critical issues found, route to ABORT (condition: "rejected")
**Review Summary output contract:**
```markdown
# Review Summary
## Overall Verdict: APPROVE / REJECT
## Summary
{2-3 sentences consolidating all review results}
## Review Results
| Review | Result | Key Findings |
|--------|--------|--------------|
| Architecture | APPROVE/REJECT | {Brief finding} |
| Security | APPROVE/REJECT | {Brief finding} |
| AI Antipattern | APPROVE/REJECT | {Brief finding} |
## Issues Requiring Attention
| # | Severity | Source | Location | Issue |
|---|----------|--------|----------|-------|
| 1 | High | Security | `file:line` | Description |
## Improvement Suggestions
- {Consolidated suggestions from all reviews}
```
output_contracts:
- Review Summary: 04-review-summary.md
- name: pr-comment
edit: false
persona: pr-commenter
allowed_tools:
- Read
- Glob
- Grep
- Bash
rules:
- condition: Comments posted
next: COMPLETE
- condition: Failed to post comments
next: COMPLETE
instruction_template: |
## Review Summary
{previous_response}
Post the review results to the PR as comments.
**Procedure:**
1. Extract the PR number from the task description
2. Read all review reports in the Report Directory:
- `01-architect-review.md` (Architecture review)
- `02-security-review.md` (Security review)
- `03-ai-review.md` (AI antipattern review)
- `04-review-summary.md` (Consolidated summary)
3. Filter findings by severity and post inline comments for Critical/High/Medium
4. Post a summary comment with the following format:
```
## Automated Review Summary
{Overall verdict and summary from 04-review-summary.md}
### Review Results
| Review | Result |
|--------|--------|
| Architecture | {result} |
| Security | {result} |
| AI Antipattern | {result} |
### Key Findings
{Bulleted list of important findings}
### Improvement Suggestions
{Consolidated suggestions}
---
*Generated by [takt](https://github.com/toruticas/takt) review-only piece*
```
report_formats:
architecture-review: ../output-contracts/architecture-review.md
security-review: ../output-contracts/security-review.md
ai-review: ../output-contracts/ai-review.md
review-summary: ../output-contracts/review-summary.md