/** * Tests for persona_providers config-level provider override. * * Verifies the provider resolution priority: * 1. Movement YAML provider (highest) * 2. persona_providers[personaDisplayName] * 3. CLI/global provider (lowest) */ import { describe, it, expect, beforeEach, vi } from 'vitest'; vi.mock('../agents/runner.js', () => ({ runAgent: vi.fn(), })); vi.mock('../core/piece/evaluation/index.js', () => ({ detectMatchedRule: vi.fn(), })); vi.mock('../core/piece/phase-runner.js', () => ({ needsStatusJudgmentPhase: vi.fn(), runReportPhase: vi.fn(), runStatusJudgmentPhase: vi.fn(), })); vi.mock('../shared/utils/index.js', async (importOriginal) => ({ ...(await importOriginal>()), generateReportDir: vi.fn().mockReturnValue('test-report-dir'), })); import { PieceEngine } from '../core/piece/index.js'; import { runAgent } from '../agents/runner.js'; import type { PieceConfig } from '../core/models/index.js'; import { makeResponse, makeRule, makeMovement, mockRunAgentSequence, mockDetectMatchedRuleSequence, applyDefaultMocks, } from './engine-test-helpers.js'; describe('PieceEngine persona_providers override', () => { beforeEach(() => { vi.resetAllMocks(); applyDefaultMocks(); }); it('should use persona_providers when movement has no provider and persona matches', async () => { const movement = makeMovement('implement', { personaDisplayName: 'coder', rules: [makeRule('done', 'COMPLETE')], }); const config: PieceConfig = { name: 'persona-provider-test', movements: [movement], initialMovement: 'implement', maxIterations: 1, }; mockRunAgentSequence([ makeResponse({ persona: movement.persona, content: 'done' }), ]); mockDetectMatchedRuleSequence([{ index: 0, method: 'phase1_tag' }]); const engine = new PieceEngine(config, '/tmp/project', 'test task', { projectCwd: '/tmp/project', provider: 'claude', personaProviders: { coder: 'codex' }, }); await engine.run(); const options = vi.mocked(runAgent).mock.calls[0][2]; expect(options.provider).toBe('codex'); }); it('should use global provider when persona is not in persona_providers', async () => { const movement = makeMovement('plan', { personaDisplayName: 'planner', rules: [makeRule('done', 'COMPLETE')], }); const config: PieceConfig = { name: 'persona-provider-nomatch', movements: [movement], initialMovement: 'plan', maxIterations: 1, }; mockRunAgentSequence([ makeResponse({ persona: movement.persona, content: 'done' }), ]); mockDetectMatchedRuleSequence([{ index: 0, method: 'phase1_tag' }]); const engine = new PieceEngine(config, '/tmp/project', 'test task', { projectCwd: '/tmp/project', provider: 'claude', personaProviders: { coder: 'codex' }, }); await engine.run(); const options = vi.mocked(runAgent).mock.calls[0][2]; expect(options.provider).toBe('claude'); }); it('should prioritize movement provider over persona_providers', async () => { const movement = makeMovement('implement', { personaDisplayName: 'coder', provider: 'claude', rules: [makeRule('done', 'COMPLETE')], }); const config: PieceConfig = { name: 'movement-over-persona', movements: [movement], initialMovement: 'implement', maxIterations: 1, }; mockRunAgentSequence([ makeResponse({ persona: movement.persona, content: 'done' }), ]); mockDetectMatchedRuleSequence([{ index: 0, method: 'phase1_tag' }]); const engine = new PieceEngine(config, '/tmp/project', 'test task', { projectCwd: '/tmp/project', provider: 'mock', personaProviders: { coder: 'codex' }, }); await engine.run(); const options = vi.mocked(runAgent).mock.calls[0][2]; expect(options.provider).toBe('claude'); }); it('should work without persona_providers (undefined)', async () => { const movement = makeMovement('plan', { personaDisplayName: 'planner', rules: [makeRule('done', 'COMPLETE')], }); const config: PieceConfig = { name: 'no-persona-providers', movements: [movement], initialMovement: 'plan', maxIterations: 1, }; mockRunAgentSequence([ makeResponse({ persona: movement.persona, content: 'done' }), ]); mockDetectMatchedRuleSequence([{ index: 0, method: 'phase1_tag' }]); const engine = new PieceEngine(config, '/tmp/project', 'test task', { projectCwd: '/tmp/project', provider: 'claude', }); await engine.run(); const options = vi.mocked(runAgent).mock.calls[0][2]; expect(options.provider).toBe('claude'); }); it('should apply different providers to different personas in a multi-movement piece', async () => { const planMovement = makeMovement('plan', { personaDisplayName: 'planner', rules: [makeRule('done', 'implement')], }); const implementMovement = makeMovement('implement', { personaDisplayName: 'coder', rules: [makeRule('done', 'COMPLETE')], }); const config: PieceConfig = { name: 'multi-persona-providers', movements: [planMovement, implementMovement], initialMovement: 'plan', maxIterations: 3, }; mockRunAgentSequence([ makeResponse({ persona: planMovement.persona, content: 'done' }), makeResponse({ persona: implementMovement.persona, content: 'done' }), ]); mockDetectMatchedRuleSequence([ { index: 0, method: 'phase1_tag' }, { index: 0, method: 'phase1_tag' }, ]); const engine = new PieceEngine(config, '/tmp/project', 'test task', { projectCwd: '/tmp/project', provider: 'claude', personaProviders: { coder: 'codex' }, }); await engine.run(); const calls = vi.mocked(runAgent).mock.calls; // Plan movement: planner not in persona_providers → claude expect(calls[0][2].provider).toBe('claude'); // Implement movement: coder in persona_providers → codex expect(calls[1][2].provider).toBe('codex'); }); });